Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (68d1f6c) to head (859b562).

@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          24       24           
  Lines        1423     1424    +1     
=======================================
+ Hits         1316     1317    +1     
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/hold

The changes look good here @chipspeak would you mind adding verification steps, i'm happy to verify it. :)

@kryanbeane: changing LGTM is restricted to collaborators

Verification

In a jupyter notebook running on my machine
built from the is branch and installed via
%pip install ../../dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl --force-reinstall
I'm using python 3.11

Kueue Installed

Invalid Queue
Creating a Clusterconfig with a local_queue with a value that there isn't a local_queue with that name in the namespace. The output is
local_queue provided does not exist or is not in this namespace. Please provide the correct local_queue name in Cluster Configuration

Applying this cluster results in the following error

WARNING: RayCluster creation rejected by the validating admission policy. Please contact your administrator.
Unexpected API error encountered (Reason: Unprocessable Entity)
Response: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"rayclusters.ray.io \"raytest\" is forbidden: ValidatingAdmissionPolicy 'kueue-validating-admission-policy' with binding 'kueue-validating-admission-policy-binding' denied request: The label 'kueue.x-k8s.io/queue-name' is either missing or does not have a value set.","reason":"Invalid","details":{"name":"raytest","group":"ray.io","kind":"rayclusters","causes":[{"message":"ValidatingAdmissionPolicy 'kueue-validating-admission-policy' with binding 'kueue-validating-admission-policy-binding' denied request: The label 'kueue.x-k8s.io/queue-name' is either missing or does not have a value set."}]},"code":422}

Valid Queue

Creating a Clusterconfig with a local_queue with a value that there IS a. localqueue with that name in the namespace
output is
Yaml resources loaded for raytest

RayCluster is created with the label kueue.x-k8s.io/queue-name: example

Kueue Not Installed

kueue set to Removed in DSC
and localqueue crd removed from the cluster

output is

The requested resource could not be located.
Please verify the resource name and namespace.
Response: 404 page not found

local_queue provided does not exist or is not in this namespace. Please provide the correct local_queue name in Cluster Configuration
Yaml resources loaded for other

I was able to clluster.up the resulting raytest cr.

WARNING: The up() function is planned for deprecation in favor of apply().
Ray Cluster: 'other' has successfully been created

@laurafitzgerald: changing LGTM is restricted to collaborators

/ok-to-test

@laurafitzgerald: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

/ok-to-test

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane, laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/override verify-ray_job_client

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: verify-ray_job_client

/hold cancel

/override verify-0_basic_ray verify-1_cluster_job_client verify-2_basic_interactive verify-3_widget_example

@laurafitzgerald: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• verify-0_basic_ray
• verify-1_cluster_job_client

Only the following failed contexts/checkruns were expected:

• add-approve-lgtm-label
• tide
• verify-2_basic_interactive
• verify-3_widget_example
• verify-local_interactive

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.